Add reduced Beholder metric resources#2249
Draft
pkcll wants to merge 4 commits into
Draft
Conversation
Keep full OTel metadata for logs, traces, and a resource info metric while allowing metric exports to omit high-cardinality resource attributes.
Contributor
✅ API Diff Results -
|
Preserve effective resource identity while filtering all pod-scoped volatile attributes and avoid emitting the info gauge unless filtering is enabled.
Cover authoritative identity preservation, effective service identity, pod-prefix filtering, and default feature-flag behavior.
Preserve node_id from Telemetry.ResourceAttributes instead of adding a parallel Beholder and LOOP configuration path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
csa_public_keyand caller-providednode_idfrom[Telemetry.ResourceAttributes]on reduced metric resourcesbeholder.otel.resource_attributes.fullonly when filtering is enabled, retaining full metadata for inspectionFeature flags
CL_TELEMETRY_REDUCED_METRIC_RESOURCE_ATTRIBUTES_ENABLED(defaultfalse)CL_TELEMETRY_EXCLUDE_VOLATILE_RESOURCE_ATTRIBUTES_FROM_METRICS_ENABLED(defaultfalse)Test plan
go test -race ./pkg/beholder ./pkg/loopgo vet ./pkg/beholder ./pkg/loopcsa_public_key,node_id,service.name, andservice.versionremain on metricsprocess.pid,service.instance.id, andk8s.pod.*only remain onbeholder_otel_resource_attributes_fullFollow-ups
k8s.pod.*labels in infra-k8s; they are added after the SDK and cannot be removed by this change.